gui: fix TV and GamePad screenshot filenames being swapped#2009
Open
NKR0ne wants to merge 1 commit into
Open
Conversation
GenerateScreenshotFilename takes isDRC, but SaveScreenshot passes mainWindow, which is its exact inverse (VulkanRenderer::HandleScreenshotRequest passes !padView as mainWindow). The result is that TV screenshots are saved with the _GamePad suffix and GamePad screenshots are saved without it. Only the filename is affected, the image content is correct. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Comment on lines
+102
to
+103
| // GenerateScreenshotFilename takes isDRC, which is the opposite of mainWindow. Passing | ||
| // mainWindow directly gave TV captures the _GamePad suffix and GamePad captures none |
Collaborator
There was a problem hiding this comment.
IMO there's no need to leave about problems that were fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenerateScreenshotFilename(bool isDRC)is called withmainWindow, which is its exact inverse —VulkanRenderer::HandleScreenshotRequestpasses!padViewasmainWindow.So TV screenshots are saved with the
_GamePadsuffix, and GamePad screenshots are saved without it. Only the filename is affected; the image content is correct.Noticed while debugging a black screen, where a TV capture arriving labelled
_GamePadbriefly sent the investigation down the wrong path.