erreula: fix inverted IsDecideSelectLeft/RightButtonError#2008
Open
NKR0ne wants to merge 1 commit into
Open
Conversation
Both functions returned != where == was meant, so each reported true for every selection except the one it was asking about, and both returned true when no button had been selected at all (BUTTON_SELECTION::NONE). IsDecideSelectButtonError directly above uses != correctly, since it asks whether any button was selected, which is presumably where this came from. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsDecideSelectLeftButtonErrorandIsDecideSelectRightButtonErrorreturn!=where==is meant.The effect is that each reports true for every selection except the one it is asking about, and both return true when no button has been selected at all (
BUTTON_SELECTION::NONE).IsDecideSelectButtonErrorimmediately above uses!=correctly, because it asks whether any button was selected — presumably where the copy-paste originated.Affects any title that queries which ErrEula button the user pressed. Found while getting Disney Infinity past its missing-NNID dialog, where the inverted result made the title read the wrong button.