Fix Mii Maker image export feature#1984
Open
ariankordi wants to merge 5 commits into
Open
Conversation
Member
|
Appreciate the contribution, but our LLM policy requires all code to be written by a human. You can find the full policy and reasons in README.md |
…ker knows it's present." This reverts commit fa884c8.
…le that SD card was inserted.
Contributor
Author
|
Sorry about that, the SD change was from Claude with rewritten comments. I reverted and redid that one by hand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gets rid of the "please insert an SD card" error that previously showed up if you tried to use this feature, so that it now works and is fully preserved (like it is in Citra).


Mii QR codes can also export now, albehit the data is all zeroes because Mii encryption is unimplemented:

Changes made
FSAttachCallbackis slightly documented in Decaf.TM_LINEAR_GENERALto be mirrored to CPU RAM as well asTM_LINEAR_ALIGNED.FSRewindDir.--cos-mounts /path/to/hostio:/fflutility)Fixing QR codes
Proper QR code exports involve implementing ACPMiiWrap/Unwrap, which I could do, but is out of scope and well documented anyway.
WrapStoreData__31__N_15_FFLiNetwork_cpp_5a76681bFP20FFLiWrappedStoreDataPC16FFLiStoreDataCFLb