Skip to content

fix(text): Apply kerning to fix glyph overlap - #16

Draft
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix/glyph-overlap-kerning
Draft

fix(text): Apply kerning to fix glyph overlap#16
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix/glyph-overlap-kerning

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

This commit fixes a glyph overlapping issue by applying kerning during text rendering. The computeGlyphRunFromText function in src/pdf/renderers/text-renderer.ts was modified to account for kerning adjustments between glyph pairs. The logic now correctly handles surrogate pairs in Unicode strings, ensuring that kerning is applied properly and preventing rendering issues.


PR created automatically by Jules for task 15116203077267198730 started by @celsowm

This commit fixes a glyph overlapping issue by applying kerning during text rendering. The `computeGlyphRunFromText` function in `src/pdf/renderers/text-renderer.ts` was modified to account for kerning adjustments between glyph pairs. The logic now correctly handles surrogate pairs in Unicode strings, ensuring that kerning is applied properly and preventing rendering issues.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants