Improve caching of equivalent variables in analyser model.#1389
Open
hsorby wants to merge 15 commits into
Open
Improve caching of equivalent variables in analyser model.#1389hsorby wants to merge 15 commits into
hsorby wants to merge 15 commits into
Conversation
agarny
requested changes
Apr 28, 2026
agarny
left a comment
agarny
left a comment
Contributor
There was a problem hiding this comment.
Looks good and definitely faster! Nice!
AnalyserModel::AnalyserModelImpl::buildEquivalentVariablesCache() should probably be called in AnalyserModel::areEquivalentVariables() (if the cache hasn't already been built), but having said that we know that the analyser is going to call AnalyserModel::areEquivalentVariables() many times, so I guess it's fine to call AnalyserModel::AnalyserModelImpl::buildEquivalentVariablesCache() upon retrieving the analyser model?
agarny
reviewed
Apr 28, 2026
agarny
reviewed
Apr 28, 2026
agarny
requested changes
May 21, 2026
agarny
left a comment
agarny
left a comment
Contributor
There was a problem hiding this comment.
This looks. "Just" some nitpicking.
nickerso
reviewed
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.