WPF - Allow ToolTip timer configuration#4389
Conversation
Related discussion at #4048 (comment) There's still a few other cases that should be tested. |
|
❌ Build CefSharp 110.0.220-CI4686 failed (commit 9cf549765a by @amaitland) |
e1ed5ee to
e34ce46
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRefactors ChromiumWebBrowser tooltip handling: early-returns on empty tooltip text, opens/closes immediately when no timer, otherwise starts/stops an existing timer; OnLoaded now creates the DispatcherTimer only when ToolTipService.GetInitialShowDelay(this) > 0 and uses that delay as the interval. ChangesTooltip Handling Cohort
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
1 similar comment
✅ Actions performedReview triggered.
|
|
✅ Build CefSharp 138.0.330-CI5331 completed (commit d4c5b007a7 by @amaitland) |
- Can set initial show delay in xaml via existing ToolTipService e.g. ToolTipService.InitialShowDelay="100" - If InitialShowDelay = 0 then no timer is used and ToolTip is immediately shown - Previous delay was 500ms, new delay is the .Net default (typically 1000ms) Related to issue #4048
e34ce46 to
af32f7e
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
❌ Build CefSharp 149.0.20-CI5522 failed (commit 66a7c78dd1 by @amaitland) |
Related to issue #4048
Summary:
Allow programmatic configuration of ToolTip timer delay.
Changes:
OnLoaded, setting the delay dynamically is not currently supported. Simplest option is to set the delay inxamlHow Has This Been Tested?
Types of changes
Checklist:
Summary by CodeRabbit