This repository was archived by the owner on Oct 20, 2020. It is now read-only.
Removal of the json-loader dependency - #1004
Open
samylan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose the removal of the json-loader dependency. It is unmaintained, and the Webpack version used by osgjs includes natively a json loader.
In my use-case, it would helps a lot: I import OSG modules directly from source (as opposed to loading the whole distribution) to make use of the tree-shaking ability of Webpack. But the explicit use of the json-loader in "osgNameSpace.js" conflicts with the default Webpack 3/4 behavior. It forces the installation an unmaintained package and to make a special case in webpack.config.js for osgjs.