fix : support for 2.17.0 release#227
Open
mickaelsv wants to merge 1 commit into
Open
Conversation
degremont
approved these changes
Jun 10, 2026
| recov_path = glob('/proc/fs/lustre/*/%s/recovery_status' % self.label) | ||
| # Since 2.17.0, recovery_status has been moved to debugfs | ||
| recov_path = ( | ||
| glob('/proc/fs/lustre/*/%s/recovery_status' % self.label) or |
Collaborator
There was a problem hiding this comment.
(minor) better to test the most future looking path first, which is the one that is the most likely to succeed eventually, so the debugfs one.
Also, at some point, we should rely on lctl get_param , or ideally lctl list_param --path , but this is only available starting in 2.16
mickaelsv
force-pushed
the
fix-recovery-status
branch
from
ac003cc to
79a2581
Compare
degremont
approved these changes
Jun 10, 2026
degremont
requested changes
Jun 10, 2026
degremont
left a comment
degremont
left a comment
Collaborator
There was a problem hiding this comment.
Could you also fix the commit message to keep the same message style:
<component>: <change>
someting like:
Target: also read recovery_status in debugfs
Since 2.17.0, recovery_status has been moved to debugfs, fixed path parser to support this change
mickaelsv
force-pushed
the
fix-recovery-status
branch
from
79a2581 to
85d5ac4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 2.17.0, recovery_status has been moved to debugfs, fixed path parser to support this change