Cast f64 NumericDate to i64#60
Open
georgeboot wants to merge 3 commits into
Open
Conversation
Mirrors jsonwebtoken's own validate_aud toggle. When set to false the aud claim is ignored even if present, so callers don't need to maintain an allowlist of client IDs when the issuer is the only thing they care about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JWT spec states the following definition for NumericDate:
This means that numeric dates can be a f64 as well.
This PR casts the f64 to an i64 internally in the deserialisation, so support both.