fix: wire up dynamicResponseHeadersPolicyProps override - #251
Merged
Conversation
createDynamicBehaviorOptions spread overrides?.dynamicBehaviorOptions?.responseHeadersPolicy instead of overrides?.dynamicResponseHeadersPolicyProps, so the documented override prop was never applied. Matches the pattern already used for staticResponseHeadersPolicyProps and imageResponseHeadersPolicyProps. Fixes #247
cdklabs-automation
enabled auto-merge
August 25, 2026 13:36
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createDynamicBehaviorOptionsinsrc/nextjs-distribution.tswas spreadingoverrides?.dynamicBehaviorOptions?.responseHeadersPolicywhen constructing the defaultResponseHeadersPolicy, instead ofoverrides?.dynamicResponseHeadersPolicyProps— so the documenteddynamicResponseHeadersPolicyPropsoverride was silently ignored.overrides?.dynamicResponseHeadersPolicyProps, matching the existing pattern used forstaticResponseHeadersPolicyPropsandimageResponseHeadersPolicyProps.Fixes #247
Test plan
tsc --noEmitpasseseslintpasses on the changed fileoverrides.dynamicResponseHeadersPolicyPropsnow applies those props to the generatedResponseHeadersPolicy