Initial work on CDK2 upgrade - #7
Open
webbres wants to merge 12 commits into
Open
Conversation
- Cleaner dependency chain for consuming plugins needing CDK - Depend on seperate jars rather than bundled to support applying security patches - Added maven project to materialise the libs
Having the CDK libs in a seperate plugin is leading to some module related issues. For now move them into the main plugin
Re-apply missing fix for the Depiction node
- Replace deprecated methods - Allow for structure or formula input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test workflow suite for the existing nodes isn't as extensive as I would like it to be. I have fixed, updated and added additional tests. These are already pushed to the KNIME test workflow server.
Ideally I would like to have a
org.openscience.cdk.libsplugin which provides the CDK code. However, at the moment when this is done the cell renderers fail. So I've stuck with keeping the CDK 2 libs in the main plugin.Changes:
More work is needed but maybe it's worth merging in this initial stuff in case anyone else wanted to have a look?