Conversation
…cxt#687) The exchange occasionally sends the MARGIN_CALL event's position list 'p' as a JSON string (e.g. "null" or "") instead of an array. The default decoder then fails with: json: cannot unmarshal string into Go struct field .p of type []futures.WsPosition This drops the user-data stream. Add a tolerant WsPositionSlice type that treats a string value as an empty list, and use it for the MarginCallPositions field in the futures, delivery and portfolio user-data event structs (all share the same schema). Add regression tests covering the string ("null") and empty-string cases. Fixes ccxt#687
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #687 —
futures.WsUserDataServeoccasionally returns an error:The exchange sometimes sends the
MARGIN_CALLevent's position list (p) as a JSON string ("null"or"") instead of an array. The default decoder fails on that, which tears down the user-data websocket stream.Changes
WsPositionSlicetype with a customUnmarshalJSONthat treats a string value as an empty list (the field is non-essential for margin-call handling).MarginCallPositions(json:"p") field in the futures, delivery and portfolio user-data event structs (identical schema, same bug class)."null"and""cases.Verification
go test ./futures/ ./delivery/ ./portfolio/— all pass, including the two new tests that previously reproduced the decode error.go build ./...andgo vetare clean.Fixes #687