Fix import error on Python 3.10: remove trailing commas in StructuredDataType - #3
Open
abrignoni wants to merge 1 commit into
Open
Fix import error on Python 3.10: remove trailing commas in StructuredDataType#3abrignoni wants to merge 1 commit into
abrignoni wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six members of
StructuredDataTypeinccl_mozilla_reader/serialization_formats/ccl_moz_structured_clone_reader.pyhad a trailing comma afterenum.auto(), which turns the value into a tuple. Python 3.11 and newer resolveauto()inside the tuple so it still works there, but Python 3.10 fails as soon as the module is imported:This PR just removes the six trailing commas (
ARRAY_BUFFER_OBJECT_V2,DO_NOT_USE_1,DO_NOT_USE_2,TYPED_ARRAY_OBJECT_V2,DO_NOT_USE_3,DATA_VIEW_OBJECT_V2). I checked that:I ran into this through mister_skinnylegs, which ALEAPP uses. The import failure on Python 3.10 made me disable the browser artifact plugins there (abrignoni/ALEAPP#976). Since #2 set
requires-pythonto>=3.10, this small fix makes 3.10 actually work.Thanks for these tools!