added a new interactive strategy for spatial up and down arrow navigation(resolves #27)#28
Open
abansal21 wants to merge 1 commit into
Open
added a new interactive strategy for spatial up and down arrow navigation(resolves #27)#28abansal21 wants to merge 1 commit into
abansal21 wants to merge 1 commit into
Conversation
Author
|
@shayc @tinchodipalma could you please review this PR and provide feedback or suggestions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the Interactive strategy, addressing the feature request from cboard-org/cboard (Issue #1828) and #27
. In Interactive strategy, users can navigate through items using the arrow keys (up, down, left, right), and the spacebar will still allow for sequential scanning.
Changes:
Tested with cboard implementation at: https://github.com/abansal21/cboard/tree/feature/arrow-key-scanning
I'm open to suggestion to improve it.