fix(theme): support all TOML date and time variants - #644
Open
eduardoapatat wants to merge 1 commit into
Open
Conversation
Color offset and local date-times, local dates, and local times consistently using the TOML date palette rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the existing TOML date highlighting rule to cover every date and time
variant emitted by Even Better TOML's TextMate grammar:
All variants now use the existing Catppuccin
pinkpalette color.Motivation
The theme previously targeted only
constant.other.time.datetime.offset.toml.The other valid TOML date and time scopes fell back to the generic
sourceforeground color:
constant.other.time.datetime.local.tomlconstant.other.time.date.tomlconstant.other.time.time.tomlTesting
Tested using Catppuccin Mocha and Even Better TOML in the Extension Development
Host.
Developer: Inspect Editor Tokens and Scopespnpm lintsuccessfullyScreenshots
Before
After