Conversation
The previous popup border of `@thm_surface_1` is barely visible. Using `@thm_overlay_0` makes the borders consistent with the pane borders and with the style guide at https://github.com/catppuccin/catppuccin/blob/main/docs/style-guide.md#terminals.
Contributor
Author
|
Happy to rebase on top of #583 if it gets merged first. Otherwise, it would be good to update the border color there if this PR gets merged first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous popup border of
@thm_surface_1is barely visible. Using@thm_overlay_0makes the borders consistent with the pane borders and with the style guide athttps://github.com/catppuccin/catppuccin/blob/main/docs/style-guide.md#terminals.
Before:
After: