test(engine): fix M5 callback test and add port scan cancellation leak test - #145
test(engine): fix M5 callback test and add port scan cancellation leak test#145mendsec wants to merge 1 commit into
Conversation
…k test **What:** - Updated `TestSlowCallbackDoesNotStallWorkers` to use a 20ms delay instead of 5ms. - Added `TestScanPortsPrematureCancel` to verify zero goroutine/socket leakage during premature cancellation. **Why:** - To fully satisfy Milestone 5 acceptance criteria for asynchronous event validation and fine-grained context cancellation. **Impact:** - Ensures slow UI renders do not stall background scans and proves graceful termination of TCP port scanning workers. **Measurement:** - Passed `runtime.NumGoroutine()` delta assertions (`<= 3`). Co-authored-by: mendsec <12684528+mendsec@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 5 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
1 participant
What:
TestSlowCallbackDoesNotStallWorkersto use a 20ms delay instead of 5ms.TestScanPortsPrematureCancelto verify zero goroutine/socket leakage during premature cancellation.Why:
Impact:
Measurement:
runtime.NumGoroutine()delta assertions (<= 3).PR created automatically by Jules for task 6586889355267100371 started by @mendsec