Skip to content

chore: merge develop → main - #81

Merged
mendsec merged 4 commits into
mainfrom
develop
Jul 24, 2026
Merged

mendsec merged 4 commits into
mainfrom
develop

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR by github-actions[bot].

@github-actions
github-actions Bot requested a review from mendsec as a code owner July 24, 2026 21:15
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

While the PR is reported as 'up to standards' by Codacy, the implementation contains several functional defects that should be addressed before merging to main.

A critical positioning logic error was identified that causes copy buttons to overlap and become unusable on pages with multiple bare code blocks. Furthermore, the current implementation fails an acceptance criterion by including the button's own label ('Copy') in the clipboard content. The review also surfaced gaps in accessibility and environment safety (missing secure context checks) that should be resolved to ensure the feature works reliably for all users.

Test suggestions

  • Clicking the copy button correctly copies the code block's text content to the system clipboard.
  • The button UI transitions to 'Copied!' with a checkmark icon immediately after a successful copy.
  • The button UI reverts from 'Copied!' back to 'Copy' after exactly 2000ms.
  • The copy action excludes the button's own text label from the clipboard content when targeting bare 'pre' tags.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Clicking the copy button correctly copies the code block's text content to the system clipboard.
2. The button UI transitions to 'Copied!' with a checkmark icon immediately after a successful copy.
3. The button UI reverts from 'Copied!' back to 'Copy' after exactly 2000ms.
4. The copy action excludes the button's own text label from the clipboard content when targeting bare 'pre' tags.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread docs/_includes/head-custom.html Outdated
Comment thread docs/_includes/head-custom.html Outdated
Comment thread docs/_includes/head-custom.html Outdated
Comment thread docs/_includes/head-custom.html Outdated

@mendsec mendsec left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review: #81 — Merge develop → main

1. Scope & Architecture Summary

This PR merges UX enhancements to the catnet GitHub Pages landing page (docs/) and updated agent governance rules from develop into main:

  • Code Block Copy Button (head-custom.html): Added discreet .copy-btn for Rouge syntax code blocks (div.highlighter-rouge) with clipboard fallback (document.execCommand), clean text extraction excluding button labels/DOM, and dynamic accessibility (aria-label updates).
  • CTA Streamlining (_config.yml, _layouts/default.html): Disabled source zip/tarball download buttons (show_downloads: false) and added a clear "Latest Release" CTA pointing to GitHub Releases alongside "View on GitHub".
  • Badges Relocation (docs/index.md): Relocated project status badges (Release, CI, License) to the top of the content area right below the hero tagline.
  • Repository Governance (AGENTS.md, CHANGELOG.md): Added Rule 11 requiring human user approval for landing page modifications, and updated the [Unreleased] changelog section.

2. Verification & CI Status

  • Go CI / Build / Vet / Tests: Passed (0 failures).
  • Golangci-lint: Passed cleanly.
  • Codacy Static Code Analysis: Passed (0 issues).
  • Govulncheck: Passed cleanly.
  • PR Rules Enforcer: Passed.

3. Verdict

All functional, accessibility, and security recommendations have been verified and resolved.
Approved for merge into main.

@mendsec
mendsec merged commit 865f7cd into main Jul 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant