Skip to content

build: Adding option to show full stdout if a stage fails - #362

Open
jbohren wants to merge 2 commits into
mainfrom
dump-stdout-on-failure
Open

build: Adding option to show full stdout if a stage fails#362
jbohren wants to merge 2 commits into
mainfrom
dump-stdout-on-failure

Conversation

@jbohren

@jbohren jbohren commented Apr 28, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@jbohren

jbohren commented Apr 28, 2016

Copy link
Copy Markdown
Contributor Author

This fixes #361

@wjwwood

wjwwood commented Apr 28, 2016

Copy link
Copy Markdown
Member

As I mentioned in the other issue, my personal opinion is that this should be the default behavior and there could be a option or setting that switches it to the current behavior. (This underscores the need for a workspace agnostic catkin tools settings, something like ~/.catkin_tools.conf)

@mikepurvis

Copy link
Copy Markdown
Member

Strongly in support of this. Any chance it can target 0.4.3?

@wjwwood

wjwwood commented Aug 5, 2016

Copy link
Copy Markdown
Member

I was going to open a new pr that inverts the logic, so that printing stdout was the default behavior and you could configure catkin_tools through a user level config to do the current behavior. However, I haven't had time to do this. Hopefully I'll have a week to catch up on this repository and the others like rvizin the coming month.

@Levi-Armstrong

Copy link
Copy Markdown

Would this address issue #419?

@wjwwood

wjwwood commented Jan 3, 2017

Copy link
Copy Markdown
Member

@Levi-Armstrong I believe so.

@rhaschke

rhaschke commented Jan 10, 2017

Copy link
Copy Markdown
Contributor

Would this address issue #419?

@wjwwood I don't think so. #419 will be fixed with #400. This PR collects all output (stdout + stderr) from the process and prints it on stdout, doesn't it?

@wjwwood

wjwwood commented Jan 11, 2017

Copy link
Copy Markdown
Member

@rhaschke I think you may be right. I am getting the "how much to print out" versus "where to print what out" confused.

@timonegk
timonegk force-pushed the main branch 4 times, most recently from c38ccd4 to 8ef11ff Compare April 3, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants