Skip to content

fix: path endpoint support - #721

Closed
natjw wants to merge 5 commits into
catalyst:MOODLE_404_STABLEfrom
natjw:fix/path-endpoint-support
Closed

fix: path endpoint support#721
natjw wants to merge 5 commits into
catalyst:MOODLE_404_STABLEfrom
natjw:fix/path-endpoint-support

Conversation

@natjw

@natjw natjw commented Feb 16, 2026

Copy link
Copy Markdown

This adds support for path style endpoint connection.
Without this fix, connecting to minio is impossible.

@Frostist

Copy link
Copy Markdown
Contributor

There is already a repo trying to be merged for this: #716

Already 2 people have said they will test, if you test and It works for you then it can get one step closer to a merge.

@Frostist

Copy link
Copy Markdown
Contributor

This merge was opened a year ago and where the discussion is currently happening: #670

@natjw

natjw commented Apr 15, 2026

Copy link
Copy Markdown
Author

Hey @Frostist, thank you for the reply. I tested your PR and it is sadly not functional for me.
The bugfixes I did in my PR were necessary to get it working with a local minio.

For example, you set the use_path_style_endpoint to true, even though this should be set based on the value.

I also added a missing exception and a quite important fix that led to massive performance issues with the AWS SDK using the IMS.

Would you be willing to add these fixes to your PR? Then I would be willing to close mine.
I have left you my issues as a review and am willing to test it. As it stands currently, it does not work.

@Frostist

Frostist commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Go for it. Can you pull your pr into mine?

@danmarsden

Copy link
Copy Markdown
Member

closing this one as it's been reported as not working for some people. I see #739 has been opened - it would be good for affected people to test and comment there.

@danmarsden danmarsden closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants