Repository navigation
Add support for Moodle 500 and update versioning - #82
Merged
Merged
Conversation
Contributor
|
Chatted with Heena, this is a backport of an existing patch set. While I think my comments are correct and relevant, They shouldnt be addressed here, we want the plugin branches to have aligned behaviour. we SHOULD at some point align our cache factory back with core, which has moved on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81
Changes
classes/cache_factory.php
$configvariable before callingload()$this->configs[$class]after load completes (survivesfactory::reset())$configdirectly instead of$this->configs[$class]version.php
2024093002$plugin->supportedfrom[405, 405]to[405, 500]$plugin->incompatible = 501(still incompatible with 5.1+)Testing
$CFG->alternative_cache_factory_class = 'tool_forcedcache_cache_factory'php admin/cli/check_database_schema.phpOrigin
Fix backported from MOODLE_501_STABLE branch (commit pattern from upstream).