Skip to content

Add support for Moodle 500 and update versioning - #82

Merged
Peterburnett merged 2 commits into
MOODLE_405_STABLEfrom
issue81-add-support-500
Jul 28, 2026
Merged

Peterburnett merged 2 commits into
MOODLE_405_STABLEfrom
issue81-add-support-500

Conversation

@hdagheda

Copy link
Copy Markdown

Fixes #81

Changes

classes/cache_factory.php

  • Store config instance in a local $config variable before calling load()
  • Assign to $this->configs[$class] after load completes (survives factory::reset())
  • Return $config directly instead of $this->configs[$class]

version.php

  • Bump version to 2024093002
  • Change $plugin->supported from [405, 405] to [405, 500]
  • Keep $plugin->incompatible = 501 (still incompatible with 5.1+)

Testing

  1. Configure $CFG->alternative_cache_factory_class = 'tool_forcedcache_cache_factory'
  2. Run php admin/cli/check_database_schema.php
  3. Verify no cache factory exception

Origin

Fix backported from MOODLE_501_STABLE branch (commit pattern from upstream).

Comment thread classes/cache_administration_helper.php
Comment thread classes/cache_factory.php
Comment thread classes/cache_factory.php
@Peterburnett

Copy link
Copy Markdown
Contributor

Chatted with Heena, this is a backport of an existing patch set. While I think my comments are correct and relevant, They shouldnt be addressed here, we want the plugin branches to have aligned behaviour. we SHOULD at some point align our cache factory back with core, which has moved on.

@Peterburnett
Peterburnett merged commit 67fc8e8 into MOODLE_405_STABLE Jul 28, 2026
33 checks passed
@Peterburnett
Peterburnett deleted the issue81-add-support-500 branch July 28, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants