issue #174: make sure that timecompleted reset to 0 when OPERATOR_ANY - #175
Open
dmitriim wants to merge 1 commit into
Open
issue #174: make sure that timecompleted reset to 0 when OPERATOR_ANY#175dmitriim wants to merge 1 commit into
dmitriim wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a bug where the course_completed condition stored the current timestamp in timecompleted when the operator was set to "Any", causing existing completions to be excluded. The fix overrides retrieve_config_data to zero out timecompleted when OPERATOR_ANY is selected.
Changes:
- Override
retrieve_config_dataincourse_completedto resettimecompletedto 0 forOPERATOR_ANY. - Add three PHPUnit tests covering the new reset behavior, preservation for
BEFORE/AFTER, and SQL query behavior forOPERATOR_ANY. - Bump plugin version/release to
2026051400.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| classes/local/tool_dynamic_cohorts/condition/course_completed.php | Adds retrieve_config_data override to zero out timecompleted for OPERATOR_ANY. |
| tests/local/tool_dynamic_cohorts/condition/course_completed_test.php | Adds tests verifying reset, preservation, and SQL behavior. |
| version.php | Bumps version and release to 2026051400. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #174