Fix unreachable host test - #163
Merged
Merged
Conversation
cameron1729
force-pushed
the
fix-unit-tests
branch
from
June 18, 2026 03:37
6c4f926 to
871cb4d
Compare
Expect a ConnectException for connection failures instead of 503s in esrequest_test. Also mock the guzzle connection so the test doesn't depend on real network.
cameron1729
force-pushed
the
fix-unit-tests
branch
from
June 18, 2026 03:39
871cb4d to
4cc7be8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expect a
ConnectExceptionfor connection failures instead of 503s inesrequest_test.Also mock the guzzle connection so the test doesn't depend on real network.