Repository navigation
Conversation
require_logout() closes the PHP session, so completing the login in the same request made complete_user_login()'s session_regenerate_id() run against a closed session. Log the old user out and redirect back to the login endpoint so the key login runs on a clean session; the key is not consumed until after that branch, so it is still valid on the second pass. Fixes catalyst#102
Author
|
@dmitriim please check and run it. thanks |
Member
|
#125 has been merged. Closing this one off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #125.
Includes original changes from @MartinR2295 with the requested version bump to pass the CI check.
thanks @dmitriim