Bug fixes and improvements - #421
Merged
Merged
Conversation
WR492688: Issue #32 Fix: the 'static' flag can no longer be set from a raw client value. It is now only true if the request presents a 'statickey' matching an HMAC-SHA256 of the outage id keyed with a per-site secret (infopage::statickey(), lazily generated via set_config()/get_config()). maintenance_static_page::create_from_outage() now sends that computed statickey instead of static=1 when it internally fetches info.php, so the legitimate static-generation path keeps working while external forgery of the flag is no longer possible. WR492688: Issue #33 WR492688: Version bump fix
sarahjcotton
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.