Fix #234 pick up images from inline style background image - #254
Open
katerynadegtyariova wants to merge 1 commit into
Conversation
| /** | ||
| * Fetch and fixes all inline background images. | ||
| */ | ||
| private function update_inline_background_images() { |
Contributor
There was a problem hiding this comment.
Can you please add some tests to:
|
|
||
| foreach ($elements as $element) { | ||
| $style = $element->getAttribute("style"); | ||
| preg_match('/(?<=background-image)\s*:\s*url\s*\(\s*(\S+)\s*\);/', $style, $matches); |
Contributor
There was a problem hiding this comment.
This might work for this one use case but there will be a bunch of other similar use cases such as
background: url()
I'm wondering if it would be better to only match on the url() in the regex.
I'd also want some negative unit tests, eg make sure a url('data:xxxx') url isn not rewritten
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased patch from John Yao