Conversation
Contributor
|
Hi all, just bumping this PR, I think it is OK to merge. I was able to replicate the revised results exactly, using the new changes proposed in this revision. Feel free to add a replication entry on my behalf, I used a GeForce RTX 2080 Ti on a Ubuntu 21.10 machine. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replicate the MS MARCO document retrieval results.
Issue Encountered
The spacy errors mentioned in #267. This PR suggests a fix for those issues.
Experiment Results Replication
The
mrr's I got differ slightly in the 5th decimal place:fh
The expected
mrris 0.38882, but got 0.3888.sh
The expected
mrris 0.33617 but got 0.33614.Environment
Python 3.7.13
GPU: Tesla P100 (Google Colab)
See the following Colab notebooks: