Refresh the UI, remove OAuth social login, and simplify configuration#21
Merged
Conversation
df13503 to
5bcdc27
Compare
- Restyle the app to a light theme. - Remove the OAuth social login so the demo focuses on the core Castle flows: drop the OAuth gems, route, callbacks controller, model hooks, the social-login button, the related locales and specs (the original provider/uid migration is left in place; those columns are unused now). - Reduce required configuration to CASTLE_PK and CASTLE_API_SECRET. - Focus the README on the Castle workflows and refresh the screenshots.
Drop the now-unused provider/uid columns from the schema, delete the migration that added them, and remove a stale code comment referencing OAuth. No code referenced these.
9204db3 to
58a6d10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The demo now focuses on the core Castle authentication flows and is easier to spin up. It drops an unrelated third-party OAuth social login, refreshes the UI to a light theme, and trims configuration down to the two Castle keys a developer actually needs.
Changes
UserOAuth hooks, the social-login button, the related locales and specs. Also removed the now-unusedprovider/uidcolumns (schema + migration) and a stale OAuth code comment.CASTLE_API_SECRETandCASTLE_PKare needed;.env.exampleno longer references anything else.Notes
app/assets/builds/tailwind.cssis compiled output; regenerate withbin/rails tailwindcss:buildif the source changes.