Skip to content

46 allow data partitioning for parallel processing by antenna or antenna#48

Merged
Jan-Willem merged 4 commits into
mainfrom
46-allow-data-partitioning-for-parallel-processing-by-antenna-or-antenna_id
Jan 9, 2026
Merged

46 allow data partitioning for parallel processing by antenna or antenna#48
Jan-Willem merged 4 commits into
mainfrom
46-allow-data-partitioning-for-parallel-processing-by-antenna-or-antenna_id

Conversation

@Jan-Willem

Copy link
Copy Markdown
Member

@tnakazato I have added support to node_task_data_mapping so that string mapping can be done. Only exact matching is performed. I have also added an example docs/sd_tutorial.ipynb.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov

codecov Bot commented Dec 17, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/graphviper/graph_tools/coordinate_utils.py 50.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for string coordinate mapping in the node_task_data_mapping functionality, enabling parallel processing by antenna names or similar string-based dimensions. The key change implements exact string matching for coordinates with string data types (like antenna names), while maintaining numeric interpolation for traditional numeric coordinates.

Key Changes:

  • Added string coordinate handling in interpolate_data_coords_onto_parallel_coords with exact matching logic
  • Added tutorial notebook sd_tutorial.ipynb demonstrating antenna-based partitioning
  • Updated version reference in graph_building_tutorial_image.ipynb

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/graphviper/graph_tools/coordinate_utils.py Added string coordinate detection and exact matching interpolator alongside existing numeric interpolation
docs/sd_tutorial.ipynb New tutorial demonstrating parallel processing partitioned by antenna names
docs/graph_building_tutorial_image.ipynb Version bump and timestamp updates from re-execution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/graphviper/graph_tools/coordinate_utils.py Outdated
@tnakazato

Copy link
Copy Markdown
Contributor

Thanks @Jan-Willem for the fix. I have tested with my dataset and confirmed that partitioning by antenna name works. It produced a dictionary consistent with manually created one. I have approved the change.

@Jan-Willem Jan-Willem merged commit 1e8716f into main Jan 9, 2026
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow data partitioning for parallel processing by antenna (or antenna_id)

4 participants