Skip to content

make error message f-string#44

Merged
Jan-Willem merged 1 commit into
mainfrom
fix-incomplete-error-message
Nov 6, 2025
Merged

make error message f-string#44
Jan-Willem merged 1 commit into
mainfrom
fix-incomplete-error-message

Conversation

@tnakazato

Copy link
Copy Markdown
Contributor

Trivial bug fix. Just adding "f" prefix to make the plain string f-string.

@CLAassistant

CLAassistant commented Oct 30, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Oct 30, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@tnakazato

Copy link
Copy Markdown
Contributor Author

Finally, I have signed the CLA.

@tnakazato

Copy link
Copy Markdown
Contributor Author

I also found that coordinate_utils.interpolate_data_coords_onto_parallel_coords doesn't allow to set "field_name" to ps_partition parameter, although docstring says it's supported. I have no solution yet. But it seems that field_name attribute is now 1-element string list rather than string. That should be the reason of the error. If ps_partition by "field_name" is supposed to work, I will create an Issue for that.

@Jan-Willem Jan-Willem merged commit bcd6688 into main Nov 6, 2025
20 checks passed
@Jan-Willem

Copy link
Copy Markdown
Member

@tnakazato it is supposed to work. Can you please create an issue? Thanks.

@tnakazato

Copy link
Copy Markdown
Contributor Author

@Jan-Willem, I've created #45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants