Fix and enhance utils.model diagnostics part 3#959
Open
henrydingliu wants to merge 13 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #959 +/- ##
==========================================
+ Coverage 88.96% 89.05% +0.09%
==========================================
Files 89 89
Lines 5100 5072 -28
Branches 663 650 -13
==========================================
- Hits 4537 4517 -20
+ Misses 417 415 -2
+ Partials 146 140 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
fixing bug on latest
adding support for predicted triangles
adding more tests
simplifying some existing tests
Related GitHub Issue(s)
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Medium Risk
Changes diagnostic outputs (Latest/IBNR) that downstream users may rely on, though behavior is now aligned with ultimate and latest diagonal; scope is limited to a utility helper plus tests.
Overview
model_diagnosticsis updated so Latest and IBNR line up with triangle semantics: loss data is always taken throughcum_to_incr()(replacing the priorincr_to_cum()path when not grouping), and IBNR isUltimate − Latestinstead ofobj.ibnr_. The helper also accepts a fitted/predictedTriangle, rejects inputs withoutultimate_/ibnr_/ldf_, and documentsTriangle | MethodBase | Pipelinein its signature.Tests add
np.allclosechecks thatmodel_diagnosticsmatcheslatest_diagonalandultimate_on fit andpredictacross several estimators, agroupbyparity test on prism, and aValueErrorwhen passing a raw triangle; a few predict tests are simplified (fixtures, sample-weight expectations,clrdordering).Reviewed by Cursor Bugbot for commit fd8af0b. Bugbot is set up for automated code reviews on this repo. Configure here.