chore: release v1.4.34 - #3775
Merged
Merged
Conversation
Signed-off-by: Michael Freeman <mfreeman451@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR performs a release metadata bump to v1.4.34, recutting the previously unpublished v1.4.33 contents (since the v1.4.33/v1.4.33-1 tag names can’t be reused on GitHub once deleted).
Changes:
- Bump repo version from
1.4.33→1.4.34(VERSION). - Bump Helm chart
version/appVersionto1.4.34. - Update demo-prod ArgoCD source override to use
global.imageTag: v1.4.34. - Update
CHANGELOGheading and add a brief “recut” note under 1.4.34.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
VERSION |
Updates the repository release version to 1.4.34. |
helm/serviceradar/Chart.yaml |
Aligns Helm chart version and appVersion with 1.4.34. |
helm/serviceradar/.argocd-source-serviceradar-demo-prod.yaml |
Updates demo-prod ArgoCD Helm parameter global.imageTag to v1.4.34. |
CHANGELOG |
Renames the release header to v1.4.34 and records the recut rationale. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please sign the Developer Certificate of Origin
Signed-off-by: Michael Freeman mfreeman451@gmail.com
Describe your changes
Formal v1.4.34 recut.
v1.4.33andv1.4.33-1cannot be recreated: GitHub immutable releases permanently consume a tag name when the release is deleted (GH013/422 Reference update failed).Same product as the 1.4.33 staging tree (including #3772 publish/sign move and the cache-proxy SRQL test fix). Do not squash.
Issue ticket number and link
n/a — 1.4.33 tag name burned
Code checklist before requesting a review
#3772 CI (lint, gitleaks, helm, Elixir Quality) passed. #3774 (1.4.33 metadata recut) passed lint/gitleaks. Local Darwin
make testcannot run Linux clang host tools; the one remote unit failure was the cache-proxy test, now fixed.