fix(presets): exclude power plan from quick-apply presets

The Recommended / Extreme / Reset quick buttons no longer stage, monitor,
or revert the Windows power plan. The active power scheme is now isolated
as a one-time, user-initiated setup on the CPU / Power tab, so a preset
click never overwrites (Recommended/Extreme) or undoes (Reset) the user's
chosen plan.

- RecommendedPreset: drop the SetPowerPlan/ResetPowerPlan calls; remove the
  now-orphaned SetPowerPlan, ResetPowerPlan, SafeListPlans helpers and the
  unused installedPlans overloads (recipe stays for the dual-CCD guardrail).
- Settings UI blurbs note each preset leaves the power plan to the CPU/Power tab.
- Tests: lock in that Recommended/Extreme don't touch the plan and Reset
  preserves a user's manual power-plan setup.
- Docs: correct STAGED-APPLY-ARCHITECTURE.md and the wiki preset descriptions.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: carterscode

docs/STAGED-APPLY-ARCHITECTURE.md

@@ -130,9 +130,9 @@ The three buttons (`Services/RecommendedPreset.cs`):
 
 | Button | Builder | What it stages | Confirmation? |
 |---|---|---|---|
-| Apply recommended | `RecommendedPreset.ApplyToDraft` | Conservative gaming preset: the hand-picked subset of toggles at their recommended gaming value, plus services / displays / the CPU-aware power plan. **Memory Integrity / VBS and UWP AI-app removal are deliberately excluded** (security tradeoff + irreversible). Monitor + Auto-apply turned **on** for each touched setting. | none |
-| Apply extreme | `RecommendedPreset.ApplyExtremeToDraft` | Every managed toggle at its most-aggressive gaming value -- including **Memory Integrity / VBS off** and the contested **Nagle / NIC** tweaks -- plus services, displays and the CPU-aware power plan. Monitor + Auto-apply **on**. Still excludes irreversible UWP AI-app removal. | yes -- a warning `MessageBox` (kernel-driver protection / anti-cheat / reboot) before `RunPreset` is called |
-| Reset all to defaults | `RecommendedPreset.ResetToDefaultsToDraft` | Every managed setting back to its Windows out-of-box value, with Monitor + Auto-apply turned **off** so a subsequent Apply restores defaults and GamerGuardian stops re-asserting. Displays are only un-monitored (their Want is hardware-specific). UWP AI-app removals are not touched. | yes -- a warning `MessageBox` before `RunPreset` is called |
+| Apply recommended | `RecommendedPreset.ApplyToDraft` | Conservative gaming preset: the hand-picked subset of toggles at their recommended gaming value, plus services / displays. **Memory Integrity / VBS and UWP AI-app removal are deliberately excluded** (security tradeoff + irreversible), and **the power plan is excluded** -- it stays a one-time, user-initiated setup on the CPU / Power tab. Monitor + Auto-apply turned **on** for each touched setting. | none |
+| Apply extreme | `RecommendedPreset.ApplyExtremeToDraft` | Every managed toggle at its most-aggressive gaming value -- including **Memory Integrity / VBS off** and the contested **Nagle / NIC** tweaks -- plus services and displays. Monitor + Auto-apply **on**. Still excludes irreversible UWP AI-app removal, and like Recommended **does not touch the power plan** (CPU / Power tab only). | yes -- a warning `MessageBox` (kernel-driver protection / anti-cheat / reboot) before `RunPreset` is called |
+| Reset all to defaults | `RecommendedPreset.ResetToDefaultsToDraft` | Every managed setting back to its Windows out-of-box value, with Monitor + Auto-apply turned **off** so a subsequent Apply restores defaults and GamerGuardian stops re-asserting. Displays are only un-monitored (their Want is hardware-specific). UWP AI-app removals are not touched, and **the power plan is left exactly as the user set it** (isolated from the presets). | yes -- a warning `MessageBox` before `RunPreset` is called |
 
 All three are **idempotent**: each per-setting helper compares the draft's `(DesiredOn/Want, Monitor, AutoApply)` triple to the target and stages (and logs) only the deltas; a second click when everything already matches stages zero changes and reports "already correct". The `[PREF-STAGE]` `settingName` carries a `[Recommended]` / `[Extreme]` / `[Reset]` tag prefix so the log shows which preset staged each delta.
 

docs/wiki/Settings-and-tabs.md

@@ -26,7 +26,7 @@ Other conventions:
 
 App preferences and the one-click setup — not a monitored-setting tab.
 
-- **One-click setup** — three whole-config presets. Each only *stages* changes (review them per-tab, then **Apply** / **Save & close** to commit, or **Cancel** to discard) and each is idempotent, so re-running after an update only picks up the new deltas:
+- **One-click setup** — three whole-config presets. Each only *stages* changes (review them per-tab, then **Apply** / **Save & close** to commit, or **Cancel** to discard) and each is idempotent, so re-running after an update only picks up the new deltas. None of them touch the **power plan** — that's isolated as a one-time, user-initiated setup on the **CPU / Power** tab:
   - **Apply recommended** — GamerGuardian's safe gaming preset: sets each covered setting's **Want**, turns **Monitor** on, opts into **Auto-apply**. Keeps Memory Integrity / VBS **on** (security) and leaves Privacy / Debloat / the contested network tweaks for you to choose. Skips the irreversible UWP AI-app removals.
   - **Apply extreme** — everything that could even *remotely* help gaming, on: **every** toggle at its most-aggressive value — including Memory Integrity / VBS **off** and the contested Nagle / NIC tweaks — with **Monitor and Auto-apply turned on for every setting**. Disabling Memory Integrity / VBS breaks Valorant (Vanguard) and weakens malware protection, and several changes need a reboot — it asks for confirmation first.
   - **Reset all to defaults** — the inverse: stages every setting back to its **Windows default** and turns **Monitor + Auto-apply off**. Applying then restores Windows' shipped behavior (which re-enables features you may have turned off, like Copilot, ads/suggestions, and telemetry services).

src/GamerGuardian/Services/RecommendedPreset.cs

@@ -13,7 +13,7 @@ namespace GamerGuardian.Services;
 /// settings have been added picks up only the new ones; everything already
 /// in the recommended state is reported as "already correct" and skipped.</para>
 ///
-/// <para><b>Conservative.</b> Two categories are intentionally NOT in the
+/// <para><b>Conservative.</b> Three categories are intentionally NOT in the
 /// preset:
 /// <list type="bullet">
 ///   <item><b>Memory Integrity and the full VBS-stack toggle</b> -- security
@@ -23,6 +23,11 @@ namespace GamerGuardian.Services;
 ///   <item><b>UWP AI app removal</b> -- irreversible without the Microsoft
 ///     Store. Policy toggles are sufficient to disable Copilot; opt-in only
 ///     for actual uninstall.</item>
+///   <item><b>The Windows power plan</b> -- isolated by design. The active
+///     power scheme is a one-time, user-initiated setup on the CPU / Power tab
+///     (pick a prebuilt plan or build the CPU-aware optimized one). No preset
+///     button -- Recommended, Extreme, or Reset -- touches it, so the user's
+///     choice is never overwritten or reverted.</item>
 /// </list></para>
 ///
 /// <para>The preset mutates the draft directly (no per-field PropertyChanged
@@ -47,12 +52,9 @@ public sealed record Result(
     public static Result ApplyToDraft(AppConfig draft) =>
         ApplyToDraft(draft, CpuTuneCatalog.Resolve(CpuDetector.Current));
 
-    public static Result ApplyToDraft(AppConfig draft, CpuTuneResult recipe) =>
-        ApplyToDraft(draft, recipe, SafeListPlans());
-
-    // installedPlans is injectable so the power-plan step is testable without a
-    // live OS power-scheme enumeration.
-    public static Result ApplyToDraft(AppConfig draft, CpuTuneResult recipe, IDictionary<Guid, string> installedPlans)
+    // recipe drives the dual-CCD service guardrail. The power plan is NOT staged
+    // here -- it stays a one-time, user-initiated setup on the CPU / Power tab.
+    public static Result ApplyToDraft(AppConfig draft, CpuTuneResult recipe)
     {
         if (draft is null) throw new ArgumentNullException(nameof(draft));
 
@@ -88,8 +90,7 @@ public static Result ApplyToDraft(AppConfig draft, CpuTuneResult recipe, IDictio
         Count(SetToggle(g.InputInsights,   "Typing / input insights",        "ai.inputinsights",  changes));
         Count(SetToggle(g.OfficeCopilot,   "Office 365 Copilot",             "ai.office",         changes));
 
-        // ---- Power plan: CPU-aware recommended prebuilt (Balanced for modern) ----
-        Count(SetPowerPlan(g.PowerPlan, recipe, installedPlans, changes));
+        // ---- Power plan: intentionally NOT staged (isolated, one-time user setup) ----
 
         // ---- Services with a RecommendedTarget ----
         foreach (var def in ServiceCatalog.All)
@@ -131,10 +132,7 @@ public static Result ApplyToDraft(AppConfig draft, CpuTuneResult recipe, IDictio
     public static Result ApplyExtremeToDraft(AppConfig draft) =>
         ApplyExtremeToDraft(draft, CpuTuneCatalog.Resolve(CpuDetector.Current));
 
-    public static Result ApplyExtremeToDraft(AppConfig draft, CpuTuneResult recipe) =>
-        ApplyExtremeToDraft(draft, recipe, SafeListPlans());
-
-    public static Result ApplyExtremeToDraft(AppConfig draft, CpuTuneResult recipe, IDictionary<Guid, string> installedPlans)
+    public static Result ApplyExtremeToDraft(AppConfig draft, CpuTuneResult recipe)
     {
         if (draft is null) throw new ArgumentNullException(nameof(draft));
 
@@ -149,9 +147,8 @@ public static Result ApplyExtremeToDraft(AppConfig draft, CpuTuneResult recipe,
             Count(SetToggleTo(pref, label, desiredOn, monitor: true, autoApply: true, "Extreme", changes));
         }
 
-        // Power plan: still the CPU-aware prebuilt (never blindly High Performance).
-        // Building the custom optimized scheme stays an explicit CPU/Power action.
-        Count(SetPowerPlan(g.PowerPlan, recipe, installedPlans, changes));
+        // Power plan: intentionally NOT staged. Even Extreme leaves the active
+        // power scheme to the user's one-time CPU / Power tab setup.
 
         foreach (var def in ServiceCatalog.All)
         {
@@ -182,12 +179,11 @@ public static Result ApplyExtremeToDraft(AppConfig draft, CpuTuneResult recipe,
     // Windows out-of-box value and turn Monitor + Auto-apply OFF, so a subsequent
     // Apply restores Windows defaults and GamerGuardian stops re-asserting anything.
     // Displays are only un-monitored (their Want is hardware-specific, so it's left
-    // alone). UWP AI app removals are not touched (reinstalling is Store-only).
+    // alone). UWP AI app removals are not touched (reinstalling is Store-only). The
+    // power plan is also left alone -- it's an isolated, user-owned one-time setup,
+    // so Reset never reverts or un-monitors it.
 
-    public static Result ResetToDefaultsToDraft(AppConfig draft) =>
-        ResetToDefaultsToDraft(draft, SafeListPlans());
-
-    public static Result ResetToDefaultsToDraft(AppConfig draft, IDictionary<Guid, string> installedPlans)
+    public static Result ResetToDefaultsToDraft(AppConfig draft)
     {
         if (draft is null) throw new ArgumentNullException(nameof(draft));
 
@@ -202,7 +198,8 @@ public static Result ResetToDefaultsToDraft(AppConfig draft, IDictionary<Guid, s
             Count(SetToggleTo(pref, label, desiredOn, monitor: false, autoApply: false, "Reset", changes));
         }
 
-        Count(ResetPowerPlan(g.PowerPlan, installedPlans, changes));
+        // Power plan: intentionally NOT reset. The user's one-time power-plan
+        // setup is isolated from the presets and left untouched.
 
         // Reset only services the user is actually managing -- don't materialize a
         // Default pref for every catalog entry the user never touched.
@@ -219,31 +216,6 @@ public static Result ResetToDefaultsToDraft(AppConfig draft, IDictionary<Guid, s
         return new Result(changed, alreadyCorrect, changes);
     }
 
-    private static bool ResetPowerPlan(PowerPlanPref pref, IDictionary<Guid, string> plans, List<string> changes)
-    {
-        // Windows default plan is Balanced. Stage it (unmanaged) if it's installed;
-        // otherwise just stop monitoring whatever plan is selected.
-        var balanced = PowerPlanMonitor.Balanced;
-        plans.TryGetValue(balanced, out var name);
-        var guidStr = balanced.ToString();
-
-        bool already = !pref.Monitor && !pref.AutoApply
-                       && pref.Desired == PowerPlanChoice.Balanced
-                       && (name is null || string.Equals(pref.DesiredGuid, guidStr, StringComparison.OrdinalIgnoreCase));
-        if (already) return false;
-
-        var before = pref.DesiredName ?? pref.Desired.ToString();
-        pref.Desired = PowerPlanChoice.Balanced;
-        if (name is not null) { pref.DesiredGuid = guidStr; pref.DesiredName = name; }
-        pref.Monitor = false;
-        pref.AutoApply = false;
-        ChangeLogger.LogPreferenceChange("[Reset] Power plan", "preset",
-            $"Want={before}",
-            $"Want={name ?? "Balanced"} Monitor=Off AutoApply=Off");
-        changes.Add($"Power plan: Balanced (Windows default), Monitor off, Auto-apply off");
-        return true;
-    }
-
     private static bool ResetDisplay(DisplayPreference dp, string label, List<string> changes)
     {
         bool changed = false;
@@ -375,36 +347,6 @@ private static bool SetRefresh(RefreshRatePref pref, string label, List<string>
         return true;
     }
 
-    private static bool SetPowerPlan(PowerPlanPref pref, CpuTuneResult recipe,
-        IDictionary<Guid, string> plans, List<string> changes)
-    {
-        // CPU-aware: recommend the prebuilt plan the catalog picked (Balanced for
-        // modern CPUs) -- never blindly High Performance. Building the custom
-        // optimized plan stays an explicit action on the CPU / Power tab. If the
-        // recommended plan isn't installed, leave the power plan alone.
-        var choice = recipe.RecommendedPrebuilt;
-        var targetGuid = PowerPlanMonitor.ToGuid(choice);
-        if (!plans.TryGetValue(targetGuid, out var name))
-            return false;
-
-        var guidStr = targetGuid.ToString();
-        var (bGuid, bMon, bAuto) = (pref.DesiredGuid, pref.Monitor, pref.AutoApply);
-        bool already = string.Equals(bGuid, guidStr, StringComparison.OrdinalIgnoreCase)
-                       && bMon && bAuto && pref.Desired == choice;
-        if (already) return false;
-
-        pref.DesiredGuid = guidStr;
-        pref.DesiredName = name;
-        pref.Desired = choice;
-        pref.Monitor = true;
-        pref.AutoApply = true;
-        ChangeLogger.LogPreferenceChange("[Recommended] Power plan", "preset",
-            $"Want={bGuid ?? "(unset)"} Monitor={B(bMon)} AutoApply={B(bAuto)}",
-            $"Want={name} Monitor=On AutoApply=On");
-        changes.Add($"Power plan: {name} (CPU-aware recommendation), Monitor on, Auto-apply on");
-        return true;
-    }
-
     /// <summary>True when the service backs the AMD CCD-routing stack / Game Bar
     /// and the detected CPU is asymmetric dual-CCD X3D (so it must not be disabled).</summary>
     public static bool ShouldProtectServiceOnDualCcd(string serviceName, CpuTuneResult recipe)
@@ -414,11 +356,5 @@ public static bool ShouldProtectServiceOnDualCcd(string serviceName, CpuTuneResu
             serviceName.Contains(f, StringComparison.OrdinalIgnoreCase));
     }
 
-    private static IDictionary<Guid, string> SafeListPlans()
-    {
-        try { return Monitors.PowerPlanMonitor.ListAvailablePlans(); }
-        catch { return new Dictionary<Guid, string>(); }
-    }
-
     private static string B(bool x) => x ? "On" : "Off";
 }

src/GamerGuardian/UI/SettingsWindow.xaml

@@ -160,15 +160,15 @@
                                     <StackPanel Margin="0,4,0,0">
                                         <TextBlock TextWrapping="Wrap" FontSize="12"
                                                    Foreground="{DynamicResource TextFillColorSecondaryBrush}">
-                                            <Run FontWeight="SemiBold" Text="Apply recommended"/><Run Text=" -- GamerGuardian's safe gaming preset: sets the recommended Want, Monitor on, Auto-apply on. Keeps Memory Integrity / VBS on (security) and leaves Privacy / Debloat / contested network tweaks for you to choose."/>
+                                            <Run FontWeight="SemiBold" Text="Apply recommended"/><Run Text=" -- GamerGuardian's safe gaming preset: sets the recommended Want, Monitor on, Auto-apply on. Keeps Memory Integrity / VBS on (security) and leaves Privacy / Debloat / contested network tweaks for you to choose. Does not touch your power plan -- set that once yourself on the CPU / Power tab."/>
                                         </TextBlock>
                                         <TextBlock TextWrapping="Wrap" FontSize="12" Margin="0,4,0,0"
                                                    Foreground="{DynamicResource TextFillColorSecondaryBrush}">
-                                            <Run FontWeight="SemiBold" Text="Apply extreme"/><Run Text=" -- everything that could even remotely help gaming, on: every toggle at its most-aggressive value (including Memory Integrity / VBS OFF and the contested Nagle / NIC tweaks), with Monitor AND Auto-apply turned on for every setting. Disabling Memory Integrity / VBS breaks Valorant (Vanguard) and weakens malware protection."/>
+                                            <Run FontWeight="SemiBold" Text="Apply extreme"/><Run Text=" -- everything that could even remotely help gaming, on: every toggle at its most-aggressive value (including Memory Integrity / VBS OFF and the contested Nagle / NIC tweaks), with Monitor AND Auto-apply turned on for every setting. Disabling Memory Integrity / VBS breaks Valorant (Vanguard) and weakens malware protection. Still leaves your power plan alone -- that's a separate one-time setup on the CPU / Power tab."/>
                                         </TextBlock>
                                         <TextBlock TextWrapping="Wrap" FontSize="12" Margin="0,4,0,0"
                                                    Foreground="{DynamicResource TextFillColorSecondaryBrush}">
-                                            <Run FontWeight="SemiBold" Text="Reset all to defaults"/><Run Text=" -- stages every setting back to its Windows default and turns Monitor + Auto-apply off. Applying then restores Windows' shipped behavior (this re-enables features like Copilot, ads and telemetry services you may have turned off)."/>
+                                            <Run FontWeight="SemiBold" Text="Reset all to defaults"/><Run Text=" -- stages every setting back to its Windows default and turns Monitor + Auto-apply off. Applying then restores Windows' shipped behavior (this re-enables features like Copilot, ads and telemetry services you may have turned off). Leaves your power plan as-is -- manage that on the CPU / Power tab."/>
                                         </TextBlock>
                                     </StackPanel>
                                     <StackPanel Orientation="Horizontal" HorizontalAlignment="Right" Margin="0,12,0,0">