Fix: Repository Configuration and Code Quality Improvements - #1
Open
kostnerek wants to merge 6 commits into
Open
Fix: Repository Configuration and Code Quality Improvements#1kostnerek wants to merge 6 commits into
kostnerek wants to merge 6 commits into
Conversation
- Fix repository URLs in package.json to use correct carrotly-technologies organization - Add @types/validate-npm-package-name dependency for better type safety - Update Jest configuration to support test files and proper path mapping - Fix repository URL mismatches in package.json
- Add comprehensive contributing guide referenced in README - Fix repository clone URL to use correct carrotly-technologies organization - Provide detailed development workflow and contribution guidelines
- Remove deprecated .eslintignore and update ESLint config with proper ignores property - Enable TypeScript strict mode for better type safety - Add proper file inclusions and exclusions in TypeScript config - Configure ESLint to allow test files to import from src directory - Fix tsconfig.diagnostics.json to handle test files properly
- Add ConfigManager tests covering config creation and validation - Add project configuration tests for template context creation - Test various scenarios including minimal and full configurations - Ensure proper service handling and type conversions - All 10 tests pass successfully
- Add CI workflow with multi-Node version testing (18.x, 20.x, 22.x) - Include comprehensive quality checks: linting, type checking, tests, security audit - Add CLI functionality testing and package compatibility validation - Add release workflow with NPM publishing and Docker image building - Add automated dependency update workflow with security auditing - Include commit message linting and coverage reporting - Support for pre-release publishing and automated PR creation
- Add CI workflow status badge - Add npm version, license, and Node.js version badges - Add codecov coverage badge - Improve README visual presentation and professionalism
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes several critical issues in the repository that affect code quality, configuration, and development workflow.
Issues Fixed
🔗 Repository URL Mismatches
package.jsonURLs to point to correctcarrotly-technologies/carrotly-nest-cli.eslintignorefile that was triggering warningseslint.config.cjswith modernignorespropertysrc/🧪 Missing Test Infrastructure
test/config-manager.spec.ts,test/project-config.spec.ts)🔧 TypeScript Strict Mode
tsconfig.diagnostics.jsonto handle test files📚 Documentation Improvements
CONTRIBUTING.mdfile referenced in README🔒 Dependencies
@types/validate-npm-package-namedependencyCode Quality Improvements
thiscontext issuesVerification
✅ Build:
npm run build- Passes with strict TypeScript✅ Tests:
npm test- All 10 tests pass✅ Linting:
npm run lint- No errors or warnings✅ Type Checking: All TypeScript errors resolved
Files Changed
16 files changed (548 additions, 78 deletions)
New Files
CONTRIBUTING.md- Comprehensive contribution guidelinestest/config-manager.spec.ts- ConfigManager unit teststest/project-config.spec.ts- Project configuration testsModified Files
package.json- Fixed URLs, added types dependency, updated Jest configREADME.md- Fixed repository clone URLeslint.config.cjs- Updated with modern ignore patterns and test rulestsconfig.json- Enabled strict mode and better configurationtsconfig.diagnostics.json- Fixed root directory handlingRemoved Files
.eslintignore- Deprecated, replaced with modern ESLint configImpact
These changes make the repository more maintainable, safer, and easier for contributors to work with.