"rustfmt on save" command and fix issue on case of file not reloading on format - #58
"rustfmt on save" command and fix issue on case of file not reloading on format#58knzai wants to merge 3 commits into
Conversation
Textmate reload on filesytem changes isn't dependable, ime. Running the file contents through rustfmt directly means we don't have to save the file, which is a little better POLS, imo. Cursor can jump left or right a bit, but line interpolation works fairly well.
We/you could default it to off if you think that's too aggressive
|
It probably needs some error handling etc, but I wanted to get input (hah) first. |
|
🤷🏻♀️ Seems fine to me! You've tested this out locally and it works? Any reason I shouldn't merge this? |
|
We may want to default it off? It's a bit obnoxious to pop up an error dialogue every time you try to save with a syntax error. I like it as then I never have to deal with dirty commits. But it could be an adjustment, so perhaps opting in makes more sense? Your call, I can add a commit to default it the other way. I also only tested on my machines and setups, of course. |
Yeah, let's default to off. |
2 participants
Let me know if you want these split up, or done differently, or don't like them. :)