Cleanup code - #14
Open
bembelimen wants to merge 1 commit into
Open
Conversation
Owner
|
Hi guys!! Thank you very much for this PR!! You know when you wake up everymorning and you say to yourself "I will reply today the PR they sent on Github. No way I misst it today!!" And then the day throws lots of boring and time consuming stuff on your desk and you are not able to do it? That's what happening here... I will take care of this ASAP and I can promise at least the J4 compatibility thing will be in, no doubt. I just want to make sure the sytling you propose will also work. Also I will love to heare more about how you are using this plugin so let me know and also if you have any nice to have ideas ;) Best! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanups we did for our project. If you like someting, you can cherry pick.