Skip to content

Fix bug when building shader compiler under trinitrydev configuration - #140

Open
ccptoebeans wants to merge 1 commit into
mainfrom
cmake_map_imported_configs
Open

ccptoebeans wants to merge 1 commit into
mainfrom
cmake_map_imported_configs

Conversation

@ccptoebeans

Copy link
Copy Markdown
Member

Summary

Fix bug where when building shader compiler under trinitrydev configuration, the TARGET_RUNTIME_DLLS resolves to be empty

https://cmake.org/cmake/help/latest/prop_tgt/MAP_IMPORTED_CONFIG_CONFIG.html#prop_tgt:MAP_IMPORTED_CONFIG_%3CCONFIG%3E

The first configuration in the list found to be provided by the imported target (i.e. via IMPORTED_LOCATION_ for the mapped-to ) is selected. As a special case, an empty list element refers to the configuration-less imported target location (i.e. IMPORTED_LOCATION).

@hrafn hrafn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Internal and TrinityDev builds are failing, seemingly due to these changes.

The TrinityDev builds fail because for several things IMPORTED_LOCATION can not be found for "Internal".

The Internal builds fail because for the same things, IMPORTED_LOCATION can not be found for "TrinityDev".

Not sure how best to resolve this.

There is also a failing "Release" build, but that one can I think be safely ignored, since it's failing with an Internal Server Error (500) when uploading to Sentry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants