Repository navigation
Conversation
Space objects and effect roots pass their ball (translation curve) to their observers and, through EveChildUpdateParams, to child containers and EveChildAudio. Audio forwards it to destiny's sightline query, which skips that ball's own collision geometry, so deployables and walls no longer occlude their own emitters.
phevosccp
changed the title
phevosccp
changed the title
CCPNobody
reviewed
Oct 28, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v21.1.8
Click here for the full clang-format patch
diff --git a/trinity/TriObserverLocal.h b/trinity/TriObserverLocal.h
--- a/trinity/TriObserverLocal.h
+++ b/trinity/TriObserverLocal.h
@@ -27 +27 @@ public:
- void SetParentBall( IRoot* ball );
+ void SetParentBall( IRoot * ball );
✨ Powered by cpp-linter -- ⭐ Star • ❤️ Sponsor • 💬 Feedback
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
filipppavlov
reviewed
Nov 3, 2026
| { | ||
| if( m_observer.p != m_parentBallObserver.p ) | ||
| { | ||
| m_parentBallObserver = m_observer; |
Member
There was a problem hiding this comment.
Minor, but still. This creates a leaked emitter if the observer changes after this object is removed from the scene.
Member
Author
There was a problem hiding this comment.
Good catch, fixed in ae803cc. The cache no longer holds a reference to the observer: changing observer (SetObserver, or from Python via OnModified) marks it stale and the next SetParentBall redoes the cast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Emitters on a deployable or wall were occluded by that object's own collision, because destiny's sightline query didn't know which ball an emitter belongs to.
EveSpaceObject2andEveEffectRoot2now passm_ballPositionto their audio emitters throughITr2AudParentBall: directly to their observers, and throughEveChildUpdateParams::ballPositiontoEveChildContainerobservers andEveChildAudio. Destiny skips that ball's geometry for the emitter. It is set every frame, likeSetVisibility, and audio ignores unchanged values.Depends on carbonengine/trinityaudioapi#11.
Testing