feat(contacts): add support for iOS 18 limited contact access#137
Closed
daniloargentiero wants to merge 2 commits into
Closed
feat(contacts): add support for iOS 18 limited contact access#137daniloargentiero wants to merge 2 commits into
daniloargentiero wants to merge 2 commits into
Conversation
- Updated permissions handling to recognize and support the new `.limited` authorization status introduced in iOS 18. - Integrated `CNContactPickerViewController` to handle contact selection, including the ability to select multiple contacts. - Added support for fetching and returning contacts when the user grants limited access, ensuring proper data flow with the new privacy model. - Refactored permission request flow to handle new iOS 18 privacy features for contact access.
robingenz
requested changes
Mar 25, 2025
Comment on lines
+205
to
+224
| public func contactPicker(_ picker: CNContactPickerViewController, didSelect contacts: [CNContact]) { | ||
| let call = self.bridge?.savedCall(withID: self.pickContactCallbackId ?? "") | ||
|
|
||
| guard let call = call else { | ||
| return | ||
| } | ||
|
|
||
| var contactsArray: [JSObject] = [] | ||
| for selectedContact in contacts { | ||
| let contact = ContactPayload(selectedContact.identifier) | ||
| contact.fillData(selectedContact) | ||
| contactsArray.append(contact.getJSObject()) | ||
| } | ||
|
|
||
| call.resolve([ | ||
| "contacts": contactsArray | ||
| ]) | ||
|
|
||
| self.bridge?.releaseCall(call) | ||
| } |
Member
There was a problem hiding this comment.
How is this related to the new limited permission? Adding the new permission state should be enough.
Author
There was a problem hiding this comment.
Ok thanks, I will try if it works without this one.
There was a problem hiding this comment.
@daniloargentiero Are you still working on this?
Co-authored-by: Robin Genz <mail@robingenz.dev>
|
@daniloargentiero can you re-request a review from @robingenz ? |
|
Hi @robingenz - Do you know the status of this PR? We are hitting this road block. |
Member
|
As you can see, not all of my review comments are resolved. |
Member
|
Closed in favor of #149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.limitedauthorization status introduced in iOS 18.CNContactPickerViewControllerto handle contact selection, including the ability to select multiple contacts.