Conversation
…error handling for `configure` calls to `config_changed`
# Conflicts: # actions.yaml # metadata.yaml # poetry.lock # pyproject.toml # src/charm.py # src/core/base_workload.py # src/core/models.py # src/statuses.py # src/workload_k8s.py # src/workload_vm.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds LDAP support to Valkey, based on the specification in DA269.
Design:
ldapandldap-ca-certentity-permissionsrequest through client relation from Data Integrator to construct "auth roles" (matched againstldap-mapconfig of Valkey)ConfigManagerto a newAuthManagerAuthManagerldaps, also works withstartTLSWorkarounds / Limitations:
certificate_transfercharmlib becauseglauth-k8sonly supports thecertificate-transferinterface in v0WhoAmIcommand which is not supported by GLAuth (see https://glauth.github.io/docs/limitations.html)Unrelated:
config setinValkeyClientclass+ping +rolepermissions to external client users to allow users to check if they are connected to a primary or replica instance (addresses Integration users don't have PING permission #80)