fix: align cryptography version and fix Renovate group config - #1189
Closed
srbouffard wants to merge 1 commit into
Closed
fix: align cryptography version and fix Renovate group config#1189srbouffard wants to merge 1 commit into
srbouffard wants to merge 1 commit into
Conversation
charmcraft.yaml had cryptography==46.0.4 while requirements.txt was already at ==48.0.0, causing Renovate to open two spurious PRs (minor and major) touching only charmcraft.yaml. - Align charmcraft.yaml to cryptography==48.0.0 to match requirements.txt - Add separateMajorMinor: false to the charm-binary-python-packages group rule so future updates are always a single PR regardless of semver bump Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
srbouffard
requested review from
DeeKay3,
Thanhphan1147 and
nrobinaubertin
as code owners
May 28, 2026 20:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two bugs introduced when the
charm-binary-python-packagesRenovate tracking was added:Version mismatch:
charmcraft.yamlwas pinned tocryptography==46.0.4whilerequirements.txtwas already at==48.0.0. This caused Renovate to open two PRs (chore(deps): update dependency cryptography to v46.0.7 - autoclosed #1187, chore(deps): update dependency cryptography to v48 #1188) that only touchedcharmcraft.yaml, without updatingrequirements.txt.Missing
separateMajorMinor: false: Without this, Renovate splits grouped updates into two separate PRs (one for minor, one for major), defeating the purpose of the group.Fix
charmcraft.yamltocryptography==48.0.0to matchrequirements.txtseparateMajorMinor: falseto thecharm-binary-python-packagespackage rule so future updates always produce a single PROnce merged, PRs #1187 and #1188 will be auto-closed by Renovate as stale.