docs: update link section of style guide - #158
Merged
Merged
Conversation
medubelko
commented
Jul 2, 2026
medubelko
commented
Contributor
- Reflow the section so it's more structured.
- Make WCAG Success Criterion 2.4.4 the prescribed pattern.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restructures the “Links” guidance in the Starcraft style guide to be more direct and prescriptive, with an accessibility-driven recommendation for link placement and updated examples.
Changes:
- Rewrote the “Links” section into a clearer stepwise set of considerations (context → benefit → accessibility guidance).
- Updated the “Good links” section heading and refined an example to better fit the recommended pattern.
- Added a new “Bad links” section with concrete anti-pattern examples.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Reflow the section so it's more structured. - Make WCAG Success Criterion 2.4.4 the prescribed pattern.
medubelko
force-pushed
the
docs-style-guide-links
branch
from
July 3, 2026 00:00
5025c8b to
df3428e
Compare
jahn-junior
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.