many: use persistent secret state for recovery keys, passphrases and PINs - #17421
Open
ZeyadYasser wants to merge 14 commits into
Open
many: use persistent secret state for recovery keys, passphrases and PINs#17421ZeyadYasser wants to merge 14 commits into
ZeyadYasser wants to merge 14 commits into
Conversation
Add a new type of state for secrets backed by memfd-secret that can persists through snapd restarts by using the fdstore. This secret store fallbacks to an in-memory store if it fails to initialize a memfd-secret backed state. Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
Drop in-memory recovery key cache in favor of memfd backed secret state that can survive snapd restarts Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
Drop in-memory cache in favor of memfd backed secret state that can survive snapd restarts Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
github-actions
Bot
added
the
Needs Documentation -auto-
|
Fri Jul 31 09:00:04 UTC 2026 No spread failures reported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #17358 and should be rebased after it is merged. Relevant commits:
Drop in-memory recovery key cache and state cache for passphrase/PINs in favor of memfd-backed secret state that can survive snapd restarts.
JIRA: SNAPDENG-36926