feat(remote-build): add --project-dir argument to support build paths - #6372
Open
Tejas-Raj01 wants to merge 2 commits into
Open
feat(remote-build): add --project-dir argument to support build paths#6372Tejas-Raj01 wants to merge 2 commits into
Tejas-Raj01 wants to merge 2 commits into
Conversation
Contributor
Author
|
@mr-cal , @medubelko , @cmatsuoka , @bepri Since these are mostly pytest fixtures, adding
Let me know the preferred approach for the repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6287
Describe your changes:
This PR introduces the
--project-dircommand-line argument for thesnapcraft remote-buildcommand to support monorepo setups and custom build paths, fulfilling the requirements outlined in Issue #6287.Key Technical Details:
--project-diroption insnapcraft/commands/remote.py, mapping it to the newly supportedbuild_pathparameter in upstreamcraft-application.tests/unit/commands/test_remote.pyto verify the argument parsing and API calls. A pre-existing test fixture (test_multiple_artifacts_per_build_on) was bypassed for thePLR0917linter rule using# noqa: PLR0917to keep the PR scope focused and avoid unrelated refactoring.tests/spread/core24/remote-build/(includingtask.yaml,arguments.txt,expected-snaps.txt, and dummy project data) to exercise the--project-dirfunctionality in a remote build scenario.docs/release-notes/snapcraft-9-0.rstunder the "Minor features" section.make lint && make test.