docs: add a "pack a Pro snap" how-to - #6367
Conversation
| "catkin-pkg==1.1.0; sys_platform == 'linux'", | ||
| "click>=8.3.3", | ||
| "craft-application[remote]>=7.1.0", | ||
| "craft-application[remote] @ git+https://github.com/canonical/craft-application@work/CRAFT-5237/pro-docs", |
There was a problem hiding this comment.
Reminder to bump before landing
There was a problem hiding this comment.
Pull request overview
Adds a new Snapcraft how-to page for packing Ubuntu Pro–compliant snaps by composing (and partially overriding) shared Craft Application documentation, and wires it into the Crafting docs navigation. The PR also temporarily switches craft-application to a git dependency to pick up the required shared-doc content.
Changes:
- Add
pack-a-pro-snaphow-to (Core24+ via shared docs include; Core22 legacy guidance inline). - Link the new how-to from
docs/how-to/crafting/index.rst. - Point
craft-applicationdependency (and lockfile) at a git ref to obtain the needed shared docs.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| uv.lock | Switches craft-application resolution from PyPI to a git source to pick up upstream docs content. |
| pyproject.toml | Updates runtime dependency on craft-application to a git ref for the same reason. |
| docs/how-to/crafting/pack-a-pro-snap.rst | New how-to page combining shared Craft Application docs with Snapcraft-specific Core22 legacy instructions. |
| docs/how-to/crafting/index.rst | Adds the new how-to to the Crafting section list and hidden toctree. |
925e265 to
df59147
Compare
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
df59147 to
8772b47
Compare
medubelko
left a comment
There was a problem hiding this comment.
This one got a little away from me. Apologies for the extra review.
| specify-a-base | ||
| select-platforms | ||
| manage-dependencies | ||
| pack-a-pro-snap |
There was a problem hiding this comment.
Let's move this to the end of the list. The homepage progress has made the existing TOC taste bad to me.
| .. include:: ../../common/craft-application/how-to-guides/pack-a-pro-artifact.rst | ||
| :end-before: .. Split point for downstream docs: Prerequisites onward |
There was a problem hiding this comment.
There's an inconsistency here. The title is transcluded, but the first heading isn't. If this is override is needed, then I don't think it's worth transcluding the title – may as well write it here, and transclude the two sections, without headings.
There was a problem hiding this comment.
Nice catch, I simplified it to "begin overview" and "end overview". Hopefully that makes it easier to read the rst and is properly transcluded.
| .. include:: ../../common/craft-application/how-to-guides/pack-a-pro-artifact.rst | ||
| :end-before: .. Split point for downstream docs: Prerequisites onward |
| Core22 snaps use a legacy mechanism to pack Pro-compliant snaps. As a result, it uses | ||
| the previous name UA (Ubuntu Advantage) instead of Ubuntu Pro. |
There was a problem hiding this comment.
Forgive the nitpick that I didn't raise earlier:
| Core22 snaps use a legacy mechanism to pack Pro-compliant snaps. As a result, it uses | |
| the previous name UA (Ubuntu Advantage) instead of Ubuntu Pro. | |
| Core22 snaps use a legacy mechanism to pack Pro-compliant snaps. The mechanism uses the | |
| term *Ubuntu Advantage* (UA) instead of *Ubuntu Pro*. |
| services. The Ubuntu Pro Client documentation has `further information | ||
| <https://documentation.ubuntu.com/pro-client/en/v32/explanations/which_services/>`__ on | ||
| each service. |
There was a problem hiding this comment.
| services. The Ubuntu Pro Client documentation has `further information | |
| <https://documentation.ubuntu.com/pro-client/en/v32/explanations/which_services/>`__ on | |
| each service. | |
| services. The Ubuntu Pro Client documentation has `detailed information on each service | |
| <https://documentation.ubuntu.com/pro-client/en/v32/explanations/which_services/>`__. |
There was a problem hiding this comment.
Alternatively, we could link this in the side bar with seealso.
There was a problem hiding this comment.
Interesting, I hadn't seen seealso before. Like the seealsos on this page? I don't see anything in the sidebar on that page for the links.
There was a problem hiding this comment.
ffb2c98 (I went with the first suggestion in the interim)
| <https://documentation.ubuntu.com/pro-client/en/v32/explanations/which_services/>`__ on | ||
| each service. | ||
|
|
||
| To enable the desired Pro services when building your snap, add a ua-services key to |
There was a problem hiding this comment.
| To enable the desired Pro services when building your snap, add a ua-services key to | |
| Add a ``ua-services`` key to your snap, and list the services: |
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Adds a Pack a Pro snap how-to document.
Blocked by canonical/craft-application#1144
(CRAFT-5236)
make lint && make test.