Skip to content

docs: add a "pack a Pro snap" how-to - #6367

Open
mr-cal wants to merge 4 commits into
mainfrom
work/CRAFT-5236/pro-docs
Open

docs: add a "pack a Pro snap" how-to #6367
mr-cal wants to merge 4 commits into
mainfrom
work/CRAFT-5236/pro-docs

Conversation

@mr-cal

@mr-cal mr-cal commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Adds a Pack a Pro snap how-to document.

Blocked by canonical/craft-application#1144
(CRAFT-5236)


  • I've followed the contribution guidelines.
  • I've signed the CLA.
  • I've successfully run make lint && make test.
  • I've added or updated any relevant documentation.
  • In documents I changed, I added a meta description if one was missing.
  • I've updated the relevant release notes.

Copilot AI review requested due to automatic review settings July 22, 2026 16:28
@mr-cal mr-cal changed the title docs" add docs: add a "pack a Pro snap" how-to Jul 22, 2026
Comment thread pyproject.toml
"catkin-pkg==1.1.0; sys_platform == 'linux'",
"click>=8.3.3",
"craft-application[remote]>=7.1.0",
"craft-application[remote] @ git+https://github.com/canonical/craft-application@work/CRAFT-5237/pro-docs",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to bump before landing

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Snapcraft how-to page for packing Ubuntu Pro–compliant snaps by composing (and partially overriding) shared Craft Application documentation, and wires it into the Crafting docs navigation. The PR also temporarily switches craft-application to a git dependency to pick up the required shared-doc content.

Changes:

  • Add pack-a-pro-snap how-to (Core24+ via shared docs include; Core22 legacy guidance inline).
  • Link the new how-to from docs/how-to/crafting/index.rst.
  • Point craft-application dependency (and lockfile) at a git ref to obtain the needed shared docs.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.

File Description
uv.lock Switches craft-application resolution from PyPI to a git source to pick up upstream docs content.
pyproject.toml Updates runtime dependency on craft-application to a git ref for the same reason.
docs/how-to/crafting/pack-a-pro-snap.rst New how-to page combining shared Craft Application docs with Snapcraft-specific Core22 legacy instructions.
docs/how-to/crafting/index.rst Adds the new how-to to the Crafting section list and hidden toctree.

Comment thread pyproject.toml
Comment thread docs/how-to/crafting/pack-a-pro-snap.rst Outdated
Comment thread docs/how-to/crafting/pack-a-pro-snap.rst
Comment thread docs/how-to/crafting/pack-a-pro-snap.rst
Comment thread docs/how-to/crafting/pack-a-pro-snap.rst Outdated
Comment thread docs/how-to/crafting/pack-a-pro-snap.rst
@mr-cal
mr-cal force-pushed the work/CRAFT-5236/pro-docs branch from 925e265 to df59147 Compare July 22, 2026 17:56
mr-cal added 2 commits July 22, 2026 14:07
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
mr-cal force-pushed the work/CRAFT-5236/pro-docs branch from df59147 to 8772b47 Compare July 22, 2026 19:07
@mr-cal
mr-cal marked this pull request as ready for review July 22, 2026 21:06
@mr-cal
mr-cal requested a review from a team as a code owner July 22, 2026 21:06
@mr-cal
mr-cal requested review from medubelko and steinbro and removed request for a team July 22, 2026 21:06

@medubelko medubelko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one got a little away from me. Apologies for the extra review.

Comment thread docs/how-to/crafting/index.rst Outdated
specify-a-base
select-platforms
manage-dependencies
pack-a-pro-snap

@medubelko medubelko Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to the end of the list. The homepage progress has made the existing TOC taste bad to me.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +10 to +11
.. include:: ../../common/craft-application/how-to-guides/pack-a-pro-artifact.rst
:end-before: .. Split point for downstream docs: Prerequisites onward

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an inconsistency here. The title is transcluded, but the first heading isn't. If this is override is needed, then I don't think it's worth transcluding the title – may as well write it here, and transclude the two sections, without headings.

@mr-cal mr-cal Jul 23, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ffb2c98

Nice catch, I simplified it to "begin overview" and "end overview". Hopefully that makes it easier to read the rst and is properly transcluded.

Comment on lines +10 to +11
.. include:: ../../common/craft-application/how-to-guides/pack-a-pro-artifact.rst
:end-before: .. Split point for downstream docs: Prerequisites onward

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onward

And upward?

Comment on lines +22 to +23
Core22 snaps use a legacy mechanism to pack Pro-compliant snaps. As a result, it uses
the previous name UA (Ubuntu Advantage) instead of Ubuntu Pro.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgive the nitpick that I didn't raise earlier:

Suggested change
Core22 snaps use a legacy mechanism to pack Pro-compliant snaps. As a result, it uses
the previous name UA (Ubuntu Advantage) instead of Ubuntu Pro.
Core22 snaps use a legacy mechanism to pack Pro-compliant snaps. The mechanism uses the
term *Ubuntu Advantage* (UA) instead of *Ubuntu Pro*.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +43 to +45
services. The Ubuntu Pro Client documentation has `further information
<https://documentation.ubuntu.com/pro-client/en/v32/explanations/which_services/>`__ on
each service.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
services. The Ubuntu Pro Client documentation has `further information
<https://documentation.ubuntu.com/pro-client/en/v32/explanations/which_services/>`__ on
each service.
services. The Ubuntu Pro Client documentation has `detailed information on each service
<https://documentation.ubuntu.com/pro-client/en/v32/explanations/which_services/>`__.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we could link this in the side bar with seealso.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I hadn't seen seealso before. Like the seealsos on this page? I don't see anything in the sidebar on that page for the links.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ffb2c98 (I went with the first suggestion in the interim)

<https://documentation.ubuntu.com/pro-client/en/v32/explanations/which_services/>`__ on
each service.

To enable the desired Pro services when building your snap, add a ua-services key to

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To enable the desired Pro services when building your snap, add a ua-services key to
Add a ``ua-services`` key to your snap, and list the services:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mr-cal added 2 commits July 23, 2026 12:03
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
mr-cal requested a review from medubelko July 23, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants