Skip to content

feat(extensions): Add core26 support to the gnome extension - #6278

Open
aleasto wants to merge 6 commits into
canonical:mainfrom
aleasto:gnome-core26
Open

feat(extensions): Add core26 support to the gnome extension#6278
aleasto wants to merge 6 commits into
canonical:mainfrom
aleasto:gnome-core26

Conversation

@aleasto

@aleasto aleasto commented Jun 4, 2026

Copy link
Copy Markdown
Member

Update the GNOME extension for core26

sample core26 GNOME app: kenvandine/fractal-snap#15


  • I've followed the contribution guidelines.
  • I've signed the CLA.
  • I've successfully run make lint && make test.
  • I've added or updated any relevant documentation.
  • In documents I changed, I added a meta description if one was missing.
  • I've updated the relevant release notes.

@aleasto
aleasto requested review from bepri and mr-cal as code owners June 4, 2026 19:13
@aleasto
aleasto marked this pull request as draft June 4, 2026 19:13
@aleasto aleasto changed the title Gnome core26 feat(extensions): Add core26 support to the gnome extension Jun 5, 2026
Copilot AI review requested due to automatic review settings July 6, 2026 16:14
@aleasto
aleasto marked this pull request as ready for review July 6, 2026 16:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GNOME extension to support the core26 base, aligning it with newer runtime/SDK naming and adding core26-specific runtime integration.

Changes:

  • Add core26 to the GNOME extension’s supported bases and reflect it in the “extensions” listing output.
  • Introduce core26-specific root snippet layout binding for glycin-loaders.
  • Add a core26-specific parts cleanup step intended to prune shared libraries from staged snaps, and extend unit tests for core26 root snippet behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
snapcraft/extensions/gnome.py Adds core26 support, new glycin layout, and a core26 cleanup part (but currently contains a broken find command).
tests/unit/extensions/test_gnome.py Adds a core26 fixture and a glycin layout assertion.
tests/unit/commands/test_list_extensions.py Updates expected “gnome” supported bases to include core26.
extensions/desktop/command-chain/Makefile Disables parallel make execution via .NOTPARALLEL:.
extensions/desktop/command-chain-kde/Makefile Disables parallel make execution via .NOTPARALLEL:.

Comment thread snapcraft/extensions/gnome.py Outdated
Comment thread snapcraft/extensions/gnome.py
Comment thread snapcraft/extensions/gnome.py
Comment thread snapcraft/extensions/gnome.py
Comment thread snapcraft/extensions/gnome.py

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comment thread tests/unit/extensions/test_gnome.py
aleasto added 4 commits July 9, 2026 14:26
Running multiple `install` commands in parallel creates a race condition
on creating the directory structure. Disable parallelism in the makefile.
This is a first pass on a cleanup part.
It is not very smart, but it takes care of the most important reason for why
we need a cleanup part: removing libraries that we already provide in the SDK
so that they cannot end up older and with missing symbols when loaded by other
libraries in the SDK.
Comment thread tests/unit/extensions/test_gnome.py

@mr-cal mr-cal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

I see the core26 gnome spread test is failing on Error installing snap 'gnome-core26' from channel 'latest/stable'. Does this PR need to wait on that to be released to stable first?

@aleasto

aleasto commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

Changes look good to me.

I see the core26 gnome spread test is failing on Error installing snap 'gnome-core26' from channel 'latest/stable'. Does this PR need to wait on that to be released to stable first?

Ah, the test must have been run before I promoted the builds to stable. It is already available in latest/stable now. You may retry the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants