feat(extensions): Add core26 support to the gnome extension - #6278
feat(extensions): Add core26 support to the gnome extension#6278aleasto wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the GNOME extension to support the core26 base, aligning it with newer runtime/SDK naming and adding core26-specific runtime integration.
Changes:
- Add
core26to the GNOME extension’s supported bases and reflect it in the “extensions” listing output. - Introduce core26-specific root snippet layout binding for
glycin-loaders. - Add a core26-specific parts cleanup step intended to prune shared libraries from staged snaps, and extend unit tests for core26 root snippet behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
snapcraft/extensions/gnome.py |
Adds core26 support, new glycin layout, and a core26 cleanup part (but currently contains a broken find command). |
tests/unit/extensions/test_gnome.py |
Adds a core26 fixture and a glycin layout assertion. |
tests/unit/commands/test_list_extensions.py |
Updates expected “gnome” supported bases to include core26. |
extensions/desktop/command-chain/Makefile |
Disables parallel make execution via .NOTPARALLEL:. |
extensions/desktop/command-chain-kde/Makefile |
Disables parallel make execution via .NOTPARALLEL:. |
Running multiple `install` commands in parallel creates a race condition on creating the directory structure. Disable parallelism in the makefile.
This is a first pass on a cleanup part. It is not very smart, but it takes care of the most important reason for why we need a cleanup part: removing libraries that we already provide in the SDK so that they cannot end up older and with missing symbols when loaded by other libraries in the SDK.
mr-cal
left a comment
There was a problem hiding this comment.
Changes look good to me.
I see the core26 gnome spread test is failing on Error installing snap 'gnome-core26' from channel 'latest/stable'. Does this PR need to wait on that to be released to stable first?
Ah, the test must have been run before I promoted the builds to stable. It is already available in latest/stable now. You may retry the test |
Update the GNOME extension for core26
sample core26 GNOME app: kenvandine/fractal-snap#15
make lint && make test.