Improve heading choice in release notes#344
Open
ndyer wants to merge 1 commit into
Open
Conversation
Contributor
|
Upon closer inspection, it seems it doesn't remove it from the 
|
olivercalder
left a comment
olivercalder
left a comment
Member
There was a problem hiding this comment.
Question about matching other recent release notes.
| We’re pleased to share that Snapd 2.74 snap is available for testing in the beta channel. | ||
|
|
||
| # New in snapd 2.74 | ||
| ### New in snapd 2.74 |
Member
There was a problem hiding this comment.
2.72 and 2.73 have release notes like this:
Suggested change
| ### New in snapd 2.74 | |
| (ref-release-notes_snapd-2-74-release-notes)= | |
| ## Snapd 2.74 release notes |
Should we match the same format here?
Contributor
There was a problem hiding this comment.
I think we had decided to use markdown style formatting consistently across the project recently, maybe this was the old style?
Contributor
Author
There was a problem hiding this comment.
I think you may be right, my analysis of the issue is wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns better with the heading levels and prevents "New in snapd 2.74" appearing in the sidebar.