Skip to content

github: add GHA security scanner workflow (zizmor)#39

Merged
tomponline merged 4 commits into
canonical:mainfrom
simondeziel:zizmor
Apr 11, 2026
Merged

github: add GHA security scanner workflow (zizmor)#39
tomponline merged 4 commits into
canonical:mainfrom
simondeziel:zizmor

Conversation

@simondeziel

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@simondeziel simondeziel requested a review from Copilot April 10, 2026 20:55
@simondeziel simondeziel marked this pull request as ready for review April 10, 2026 20:56
@simondeziel

Copy link
Copy Markdown
Member Author

@tomponline would you mind enabling https://github.com/canonical/setup-lxd/security/quality, please?

@simondeziel simondeziel requested a review from tomponline April 10, 2026 20:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an automated GitHub Actions security scanning workflow (zizmor) and adjusts existing workflows/config to align with that security posture.

Changes:

  • Add a new zizmor GitHub Actions workflow to analyze workflow security.
  • Refactor composite action steps to pass inputs via step env variables (instead of direct expression interpolation).
  • Remove the “Require GHA pinning” step from the test workflow and add a Dependabot update cooldown.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
action.yml Routes inputs.* into step env variables used by bash scripts.
.github/workflows/zizmor.yml Introduces zizmor-based workflow security analysis in CI.
.github/workflows/test.yml Removes the workflow pinning enforcement step from tests.
.github/dependabot.yml Adds a Dependabot cooldown setting for GitHub Actions updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread action.yml Outdated
Comment thread action.yml Outdated
Comment thread .github/workflows/zizmor.yml
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@tomponline

Copy link
Copy Markdown
Member

@tomponline would you mind enabling https://github.com/canonical/setup-lxd/security/quality, please?

Done

@tomponline tomponline merged commit a517a53 into canonical:main Apr 11, 2026
7 checks passed
@simondeziel simondeziel deleted the zizmor branch April 11, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants