Quality improvements - #554
Merged
Merged
Conversation
frederic-hoerni
commented
Jul 21, 2026
frederic-hoerni
commented
Collaborator
- efi/pcr_profile: minor quality improvements
- Makefile: add check-efi
- efi: add pcr number on panic message
- efi/preinstall: add option --event-log
- fix call to deprecated func - fix typo - remove an item of a list that was not used
pedronis
reviewed
Jul 21, 2026
|
|
||
| var digests tpm2.DigestList | ||
| for i := 0; i <= 2; i++ { | ||
| for i := 0; i <= 1; i++ { |
Collaborator
There was a problem hiding this comment.
what's this change about?
Collaborator
Author
There was a problem hiding this comment.
The original loop creates 3 items in the list, but only the first 2 are used in the test.
This modification is to remove useless code and processing.
valentindavid
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.