Skip to content

fix(commands): reference rockcraft.yaml in extensions help #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gcomneno wants to merge 1 commit into from
Closed

fix(commands): reference rockcraft.yaml in extensions help #1210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rockcraft/commands/extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,13 @@ class ExtensionsCommand(ListExtensionsCommand, abc.ABC):


class ExpandExtensionsCommand(AppCommand, abc.ABC):
"""Expand the extensions in the snapcraft.yaml file."""
"""Expand the extensions in the rockcraft.yaml file."""

name = "expand-extensions"
help_msg = "Expand extensions in snapcraft.yaml"
help_msg = "Expand extensions in rockcraft.yaml"
overview = textwrap.dedent(
"""
Extensions listed rockcraft.yaml will be
Extensions listed in rockcraft.yaml will be
expanded and shown as output.
"""
)
Expand Down
7 changes: 7 additions & 0 deletions tests/unit/commands/test_expand_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ def setup_extensions(mock_extensions):
extensions.register(FullExtension.NAME, FullExtension)


def test_expand_extensions_help_references_rockcraft_yaml():
assert ExpandExtensionsCommand.help_msg == "Expand extensions in rockcraft.yaml"
assert "rockcraft.yaml" in ExpandExtensionsCommand.overview
assert "snapcraft.yaml" not in ExpandExtensionsCommand.help_msg
assert "snapcraft.yaml" not in ExpandExtensionsCommand.overview


@pytest.mark.usefixtures("tmp_path", "setup_extensions")
def test_expand_extensions(emitter, fake_app_config):
# ExpandExtensionsCommand loads "rockcraft.yaml" on the cwd
Expand Down